Accept deadline in write args and callback for GC results #221
+200
−81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces some considerable changes to the queue client
GCso that the code using the method can take action in batches during the process. Every batch of keys considered "expired" is given to a callback function which may choose to return a specific error to interrupt iteration. The return signature ofGCnow returns(total, nDeleted, error)so that the code using it can report accordingly.NOTE: This includes a backward-incompatible change to how "meta cancelation" entries are managed to use the bare "track value" rather than the SHA1 hex checksum of the "track value". This allows client usage to directly inspect the
meta:cancelationhash with the "track value" understood by the client like so:Part of RUNT-372 which addresses the problem of automatically + preemptively canceling work while it is still in the queue.