Skip to content

Scrub from bundle [ch2747]#17

Merged
dexhorthy merged 2 commits intoreplicatedcom:masterfrom
dexhorthy:dex/ch2742/support-bundle-option-to-scrub-of-sensitive
Oct 27, 2017
Merged

Scrub from bundle [ch2747]#17
dexhorthy merged 2 commits intoreplicatedcom:masterfrom
dexhorthy:dex/ch2742/support-bundle-option-to-scrub-of-sensitive

Conversation

@dexhorthy
Copy link
Copy Markdown
Contributor

@dexhorthy dexhorthy commented Oct 27, 2017 •
edited
Loading 

specs:
  - builtin: core.read-file
    raw: /pg/pg.env
    config:
      file_path: `+ path.Join(tmpdir, "pg.env")+ `
      scrub:
        regex: (PGPASSWORD)=(.*)
        replace: $1=REDACTED

dexhorthy
dexhorthy commented Oct 27, 2017
View reviewed changes
Comment thread cmd/generate.go
}

func generate(cmd *cobra.Command, args []string) error {
func Generate(cfgFile string, bundlePath string, skipDefault bool, timeoutSeconds int) error {
Copy link
Copy Markdown
Contributor Author

@dexhorthy dexhorthy Oct 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made this public so we can run it as integration test entrypoint without having to muck with argv

dexhorthy
dexhorthy commented Oct 27, 2017
View reviewed changes
Comment thread pkg/plans/byte-source.go
// Parser, if defined, structures the raw data for json and human sinks
Parser func([]byte) (interface{}, error)
// StructuredScrubber, if defined, rewrites the structured data to remove sensitive data
//StructedScrubber func(interface{}) (interface{}, error)
Copy link
Copy Markdown
Contributor Author

@dexhorthy dexhorthy Oct 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe coming soon?

@dexhorthy dexhorthy force-pushed the dex/ch2742/support-bundle-option-to-scrub-of-sensitive branch from e84a5aa to 45837a2 Compare October 27, 2017 20:52
@dexhorthy dexhorthy force-pushed the dex/ch2742/support-bundle-option-to-scrub-of-sensitive branch from 45837a2 to 0b1c69e Compare October 27, 2017 20:53
@dexhorthy dexhorthy merged commit 91dc3ba into replicatedcom:master Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laverya laverya laverya approved these changes

@areed areed Awaiting requested review from areed

@emosbaugh emosbaugh Awaiting requested review from emosbaugh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dexhorthy @laverya