Conversation
added 2 commits
October 27, 2017 15:54
laverya
reviewed
Oct 27, 2017
| var _ = Describe("Checking contents of the file", func() { | ||
|
|
||
| BeforeEach(EnterNewTempDir) | ||
| AfterEach(CleanupDir) |
Contributor
There was a problem hiding this comment.
Are these ginkgo builtins?
Contributor
There was a problem hiding this comment.
Nevermind, looks like they're in helpers.go
Author
There was a problem hiding this comment.
Describe, BeforeEach & AfterEach are, CleanupDir is what Dex wrote
| WriteFile("blah.txt", ` | ||
| Hey there! | ||
| Let's take a peek into my file!`) | ||
|
|
Contributor
There was a problem hiding this comment.
I personally like searching the source file itself for some random nonce, with the random nonce only on the search line like this: Expect(contents).To(ContainSubstring("MBkQAZ93qN"))
But that's really arcane and probably an antipattern.
laverya
approved these changes
Oct 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first test