Merged
Conversation
laverya
reviewed
Apr 23, 2020
| -w /go/src/$(PKG) \ | ||
| -l com.replicated.support-bundle=true \ | ||
| golang:1.10 \ | ||
| golang:1.13 \ |
Member
Author
There was a problem hiding this comment.
then i would have to bump the whole project. i was just trying to make the tests match the prod dockerfile
laverya
reviewed
Apr 23, 2020
| "sync" | ||
| "time" | ||
|
|
||
| "github.com/gobwas/glob" |
Contributor
There was a problem hiding this comment.
can we use filepath.Match instead?
It doesn't allow matching /s, but I think that would be fine for our use case, right?
Contributor
There was a problem hiding this comment.
(It's what we use in troubleshoot: https://github.com/replicatedhq/troubleshoot/blob/d016e32/pkg/redact/redact.go#L80-L106)
Member
Author
There was a problem hiding this comment.
i wanted to pre-compile the glob pattern so i could handle the error before scanning. filepath.Match does not let me
Contributor
There was a problem hiding this comment.
I should probably update troubleshoot then before we release it
laverya
approved these changes
Apr 23, 2020
emosbaugh
deleted the
emosbaugh/ch23908/support-bundle-allow-vendors-to-omit-entire
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.