Plugin structure#3
Merged
areed merged 1 commit intoreplicatedcom:masterfrom Oct 18, 2017
areed:areed/ch2395/task-interface
Merged
Plugin structure#3areed merged 1 commit intoreplicatedcom:masterfrom areed:areed/ch2395/task-interface
areed merged 1 commit intoreplicatedcom:masterfrom
areed:areed/ch2395/task-interface
Conversation
emosbaugh
reviewed
Oct 17, 2017
|
|
||
| // add an error to every result, returning the results argument | ||
| // skips results that already have an error | ||
| func resultsWithErr(err error, results []types.Result) []types.Result { |
Member
There was a problem hiding this comment.
emosbaugh
reviewed
Oct 17, 2017
| {{ with .ProcessCountRunning }}Running Processes: {{ .}}{{ end }} | ||
| {{ with .ProcessCountTotal }}Total Processes: {{ . }}{{ end }}` | ||
|
|
||
| func PlanLoadAverage(spec types.Spec) []types.Task { |
laverya
approved these changes
Oct 18, 2017
Contributor
laverya
left a comment
laverya
left a comment
There was a problem hiding this comment.
Structure all looks good. We can fix the unit tests and reimplement per-task timeouts later
Parse yaml to get specs Planners from plugins convert specs to tasks Exec routine manages concurrency Plans produce data, transform, and write files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.