Add retraced commands [ch3179]#45
Merged
dexhorthy merged 1 commit intoreplicatedcom:masterfrom Nov 9, 2017
Merged
Conversation
areed
approved these changes
Nov 9, 2017
| "github.com/replicatedcom/support-bundle/pkg/types" | ||
| ) | ||
|
|
||
| func Events(spec types.Spec) []types.Task { |
There was a problem hiding this comment.
What do you think about doing a nil check here on spec.RetracedEventsCommand and then passing as value to producers.Events?
https://github.com/replicatedcom/support-bundle/blob/master/pkg/plugins/docker/planners/run-command.go#L11
I think optional next step may be to do some kind of parsing/structuring so we can print these out more nicely, but this seems pretty good for now.
dexhorthy
force-pushed
the
dex/ch3179/replicated-audit-logs
branch
from
fae82d3 to
f076316
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think optional next step may be to do some kind of parsing/structuring so we
can print these out more nicely, but this seems pretty good for now.