chore: use a license during e2e tests #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardomaraschini
force-pushed
the
use-binary-with-license-for-testing
branch
from
f167eac to
d47b65a
Compare
ricardomaraschini
force-pushed
the
use-binary-with-license-for-testing
branch
from
d47b65a to
445f764
Compare
in order to capture problems with the embedded license we need to use a version of the embedded cluster binary with an embedded kots license.
ricardomaraschini
force-pushed
the
use-binary-with-license-for-testing
branch
from
445f764 to
21b415f
Compare
laverya
reviewed
Nov 8, 2023
laverya
reviewed
Nov 8, 2023
Comment on lines
22
to
24
| expect "Enter a new Admin Console password:" { send "password\r" } | ||
| expect "Confirm password:" { send "password\r" } | ||
| expect "Admin Console is ready!" | ||
| expect "Confirm password:" { send "password\r" } |
Member
There was a problem hiding this comment.
should we really have to type the password three times?
Contributor
Author
There was a problem hiding this comment.
My mistake. Removed.
laverya
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to capture problems with the embedded license we need to use a version of the embedded cluster binary with an embedded kots license.