fix(app): helm client initialisation #3175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Addresses a problem where we were mistakenly initialising a separate helm client with a default set of values when doing a dry run templating of the chart.
Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/130956/unable-to-install-with-new-installer
Does this PR require a test?
Changed the chart yaml we create for tests to include a
kubeVersion. In our tests we're already passing an helm client to the manager:embedded-cluster/api/internal/managers/app/release/template_test.go
Lines 341 to 346 in 532e4b1
However this was unused (hence the bug). This should at least make sure that we're not using a client initialised with the default values.
Does this PR require a release note?
Does this PR require documentation?
NONE