Skip to content

Conversation

@JGAntunes
Copy link
Member

What this PR does / why we need it:

Addresses a problem where we were mistakenly initialising a separate helm client with a default set of values when doing a dry run templating of the chart.

Which issue(s) this PR fixes:

https://app.shortcut.com/replicated/story/130956/unable-to-install-with-new-installer

Does this PR require a test?

Changed the chart yaml we create for tests to include a kubeVersion. In our tests we're already passing an helm client to the manager:

However this was unused (hence the bug). This should at least make sure that we're not using a client initialised with the default values.

Does this PR require a release note?

NONE

Does this PR require documentation?

NONE

@JGAntunes JGAntunes force-pushed the jgantunes/sc-130956/unable-to-install-with-new-installer branch from b8a00d5 to 96d2aa8 Compare November 7, 2025 18:15
@JGAntunes JGAntunes marked this pull request as ready for review November 7, 2025 18:15
@sgalsaleh sgalsaleh merged commit 2baefa5 into main Nov 10, 2025
27 checks passed
@sgalsaleh sgalsaleh deleted the jgantunes/sc-130956/unable-to-install-with-new-installer branch November 10, 2025 17:31
crdant pushed a commit that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants