feat(install): store config values in a kube secret on install #3272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGAntunes
commented
Dec 5, 2025
|
|
||
| // createConfigValuesSecret creates or updates a Kubernetes secret with the config values. | ||
| // TODO: Handle 1MB size limitation by storing large file data fields as pointers to other secrets | ||
| // TODO: Consider maintaining history of config values for potential rollbacks |
Member
Author
There was a problem hiding this comment.
I don't know if this will be required or not? Just something I was wondering as we might want to keep a couple of versions of the config values laying around for this case or if this will be entirely up to Helm and we don't need to care about it 🤔
Member
There was a problem hiding this comment.
we don't support rollbacks at this time. we can worry about it later.
JGAntunes
commented
Dec 5, 2025
Comment on lines
138
to
154
| if !apierrors.IsAlreadyExists(err) { | ||
| return fmt.Errorf("create config values secret: %w", err) | ||
| } | ||
|
|
||
| // Secret exists, delete and recreate it | ||
| existingSecret := &corev1.Secret{} | ||
| existingSecret.Name = secretName | ||
| existingSecret.Namespace = namespace | ||
|
|
||
| if err := m.kcli.Delete(ctx, existingSecret); err != nil { | ||
| return fmt.Errorf("delete existing config values secret: %w", err) | ||
| } | ||
|
|
||
| // Recreate with new data | ||
| if err := m.kcli.Create(ctx, secret); err != nil { | ||
| return fmt.Errorf("recreate config values secret: %w", err) | ||
| } |
Member
Author
There was a problem hiding this comment.
I was thinking if another secret could already be in place? And opted for just replacing it if that's the case.
JGAntunes
commented
Dec 5, 2025
Comment on lines
+113
to
+128
| // Create secret object | ||
| secret := &corev1.Secret{ | ||
| TypeMeta: metav1.TypeMeta{ | ||
| Kind: "Secret", | ||
| APIVersion: "v1", | ||
| }, | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: secretName, | ||
| Namespace: namespace, | ||
| Labels: map[string]string{ | ||
| "app.kubernetes.io/name": license.Spec.AppSlug, | ||
| "app.kubernetes.io/version": m.releaseData.ChannelRelease.VersionLabel, | ||
| "app.kubernetes.io/component": "config", | ||
| "app.kubernetes.io/part-of": "embedded-cluster", | ||
| "app.kubernetes.io/managed-by": "embedded-cluster-installer", | ||
| }, |
Member
Author
There was a problem hiding this comment.
Let me know what you think of the name and labels applied here.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Member
Author
|
I'll be adding a dryrun test assertion as follow up but for now this should be good for 👀 |
sgalsaleh
approved these changes
Dec 5, 2025
JGAntunes
deleted the
jgantunes/sc-131755/store-user-config-values-in-a-kubernetes
branch
This was referenced Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With us removing the usage of kots cli to install the app we need to keep the config values for the current app install and use that when we're running the upgrade installer.
This PR addresses the first part (creating a kube secret on install).
Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/131755/store-user-config-values-in-a-kubernetes-secret
Does this PR require a test?
Yes
Does this PR require a release note?
Does this PR require documentation?
NONE