Skip to content

Ignore host env vars as they may override the registry config#4975

Merged
sgalsaleh merged 2 commits intomainfrom
salah/sc-105931/temp-registry-does-not-come-up-and-times
Oct 31, 2024
Merged

Ignore host env vars as they may override the registry config#4975
sgalsaleh merged 2 commits intomainfrom
salah/sc-105931/temp-registry-does-not-come-up-and-times

Conversation

@sgalsaleh
Copy link
Member

@sgalsaleh sgalsaleh commented Oct 31, 2024

What this PR does / why we need it:

Fixes an issue where the config of the local registry that KOTS uses to process air gap bundles can be overridden by the host's environment variables.

Which issue(s) this PR fixes:

SC-105931

Does this PR require a test?

NONE

Does this PR require a release note?

* Fixes an issue where pushing images from the air gap bundle could time out due to the host's environment variables interfering with the internal / temporary registry used by the KOTS CLI.

Does this PR require documentation?

NONE

@sgalsaleh sgalsaleh added type::bug Something isn't working bug::normal labels Oct 31, 2024
@sgalsaleh sgalsaleh merged commit 644be5b into main Oct 31, 2024
@sgalsaleh sgalsaleh deleted the salah/sc-105931/temp-registry-does-not-come-up-and-times branch October 31, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug::normal type::bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants