chore(ci): move range-kots-version test to playwright#5167
Merged
Conversation
Member
Author
|
[sc-120670] |
Member
Author
|
Failing tests are due to rotated key. Merging |
sgalsaleh
reviewed
Mar 5, 2025
|
|
||
| const errorMessage = airgapUpdateErrorMessage(page); | ||
| await expect(errorMessage).toContainText("requires"); | ||
| await expect(errorMessage).toContainText(constants.RESTRICTIVE_TARGET_KOTS_VERSION); |
Member
There was a problem hiding this comment.
shouldn't this be min kots version not target?
Member
Author
There was a problem hiding this comment.
The test im porting it from calls it the same
return errorMsg.includes("requires") && errorMsg.includes(testRestrictiveTargetKotsVersion);
Member
There was a problem hiding this comment.
that's for install, not update
sgalsaleh
reviewed
Mar 5, 2025
|
|
||
| let errorMessage = card.getByTestId("version-download-status"); | ||
| await expect(errorMessage).toContainText("requires", { timeout: 5 * 1000 }); // 5 seconds | ||
| await expect(errorMessage).toContainText(constants.RESTRICTIVE_TARGET_KOTS_VERSION); |
sgalsaleh
reviewed
Mar 5, 2025
|
|
||
| errorMessage = card.getByTestId("version-downloading-status"); | ||
| await expect(errorMessage).toContainText("requires", { timeout: 5 * 1000 }); // 5 seconds | ||
| await expect(errorMessage).toContainText(constants.RESTRICTIVE_TARGET_KOTS_VERSION); |
sgalsaleh
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?