WIP feature(demo): add a example for cms #41
Conversation
chris-sanders
left a comment
chris-sanders
left a comment
There was a problem hiding this comment.
Why is the application name "cms" when the charts and files all seem to call it strapi? I think it should just be moved to match the application name and not a 'category' of software which is what I believe it is currently.
I know this is still marked draft, but I suggest you work on the Readme sooner than later. Thinking through a clearly communicated readme and any docs can help others give feedback and be used to set a milestone for what is in-scope for this portion of the PR.
| secret: | ||
| enabled: true | ||
| data: | ||
| APP_KEYS: "toBeModified1,toBeModified2" | ||
| API_TOKEN_SALT: tobemodified | ||
| ADMIN_JWT_SECRET: tobemodified | ||
| TRANSFER_TOKEN_SALT: tobemodified | ||
| JWT_SECRET: tobemodified | ||
| DATABASE_USERNAME: strapi | ||
| DATABASE_PASSWORD: strapi |
There was a problem hiding this comment.
Secrets shouldn't be in plain text, does this support the use of an external existing secret?
| auth: | ||
| username: strapi | ||
| password: strapi |
There was a problem hiding this comment.
As above can this reference an existing secret?
Another alternative is to auto-generate a secret and use that in the chart so that there isn't a global default people accidentally use.
| affinity: {} | ||
|
|
||
| # -- Embedded Postgres configuration | ||
| # Deploys a cluster using the CloudnativePG Operator |
There was a problem hiding this comment.
Does this / will this / include an option to use an existing external db instead?
| includes: | ||
| utils: ./taskfiles/utils.yml |
There was a problem hiding this comment.
I wonder if there are any good options for us to keep taskfiles in sync if we land on a similar pattern. Maybe the includes provides us a way to do that?
I wasn't 100% sold on the 'includes' pattern I hit a few issues with having to pass variables around, did you hit any complications with this or did it work fine for you?
How did you get this bootstrapped did you basically copy/paste/modify from wg_easy? That might be sufficient at least to start.
|
No longer relevant |
sc-119335