WAIT FOR RELEASE: Add missing requirements #2586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for replicated-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for replicated-docs-upgrade ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ajp-io
changed the title
Contributor
|
@ajp-io Sounds good. And yeah I think for things that are less likely to cause issues in the preflights, we can at a certain point decide to say: "EC also checks for some additional things which you can see in this preflight spec over here" so the list doesn't get hard to read/update |
Member
Author
|
That's a good idea. The SELinux one can stay, but the nameserver one can go then. |
paigecalvert
previously approved these changes
Sep 16, 2024
paigecalvert
previously approved these changes
Sep 16, 2024
Contributor
|
@ajp-io checking in on this one. Still waiting to merge? |
Member
Author
|
I got rid of the no longer or not yet relevant stuff. Feel free to merge if it's good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically we haven't updated the preflights to check for available space yet, so let's wait on merging this.
Also if you have thoughts on whether every little thing we preflight for should be in this list, versus having more details info separately, that would be fine too. "Linux" is a very different requirement than "no
nameserver localhostinresolv.conf.