-
Notifications
You must be signed in to change notification settings - Fork 31
Update steps for using the proxy registry in Helm installs #3141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for replicated-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for replicated-docs-upgrade ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| During Helm installations, after customers provide their license ID, a `global.replicated.dockerconfigjson` field that contains a base64 encoded Docker configuration file is automatically injected in the Helm chart values. You can use this `global.replicated.dockerconfigjson` field to create the required pull secret. | ||
| During Helm installations, after customers provide their license ID, a `global.replicated.dockerconfigjson` field that contains a base64 encoded Docker configuration file is automatically injected in the Helm chart values. You can use this `global.replicated.dockerconfigjson` field to create the pull secret required to authenticate with the proxy registry. | ||
|
|
||
| For information about how Kubernetes uses the `kubernetes.io/dockerconfigjson` Secret type to authenticate to a private image registry, see [Pull an Image from a Private Registry](https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/) in the Kubernetes documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ moved some of this preamble down to the relevant step(s)
| 1. <StepCustomDomain/> | ||
|
|
||
| 1. In your Helm chart templates, create a Kubernetes Secret to evaluate if the `global.replicated.dockerconfigjson` value is set, and then write the rendered value into a Secret on the cluster: | ||
| 1. In your Helm chart values file, set your image repository URL to the location of the image on the proxy registry. If you added a custom domain, use your custom domain. Otherwise, use `proxy.replicated.com`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ tell them to update their Helm values rather than having the user pass a values.yaml file to set the registry during install
| registry: proxy.replicated.com | ||
| repository: proxy/your-app-slug/ghcr.io/cloudnative-pg/cloudnative-pg | ||
| tag: catalog-1.24.0 | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ is it generally preferable to have separate registry and repository values over just repository (with the full url)? if so I can update the first example too do split registry and repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that's more standard
docs/vendor/helm-image-registry.mdx
Outdated
| # values.yaml | ||
| images: | ||
| your-app: | ||
| apiImageRepository: images.yourcompany.com/proxy/your-app-slug/ghcr.io/org-name/api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd probably match the style of the example below with the same reg, repo, tag fields. that's more standard anyway.
| registry: proxy.replicated.com | ||
| repository: proxy/your-app-slug/ghcr.io/cloudnative-pg/cloudnative-pg | ||
| tag: catalog-1.24.0 | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that's more standard
https://deploy-preview-3141--replicated-docs.netlify.app/vendor/helm-image-registry