Skip to content

feat: add helm-schema-violation linter rule to docs#4036

Merged
banjoh merged 4 commits into
mainfrom
evansmungai/sc-136401/replicated-registry-injects-global-replicated
May 8, 2026
Merged

feat: add helm-schema-violation linter rule to docs#4036
banjoh merged 4 commits into
mainfrom
evansmungai/sc-136401/replicated-registry-injects-global-replicated

Conversation

@banjoh
Copy link
Copy Markdown
Member

@banjoh banjoh commented May 6, 2026

Signed-off-by: Evans Mungai <evans@replicated.com>
@banjoh banjoh requested a review from a team as a code owner May 6, 2026 18:47
@netlify
Copy link
Copy Markdown

netlify Bot commented May 6, 2026

Deploy Preview for replicated-docs ready!

Name Link
🔨 Latest commit 952b195
🔍 Latest deploy log https://app.netlify.com/projects/replicated-docs/deploys/69fb9c66d13ccd0008d170b2
😎 Deploy Preview https://deploy-preview-4036--replicated-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 6, 2026

Deploy Preview for replicated-docs-upgrade ready!

Name Link
🔨 Latest commit 952b195
🔍 Latest deploy log https://app.netlify.com/projects/replicated-docs-upgrade/deploys/69fb9c66669e6d0008a42e4d
😎 Deploy Preview https://deploy-preview-4036--replicated-docs-upgrade.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@replicated-ci replicated-ci added type::docs Improvements or additions to documentation type::feature labels May 6, 2026
Signed-off-by: Evans Mungai <evans@replicated.com>
Comment thread docs/reference/linter.mdx
</tr>
</table>

### helm-schema-violation
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Replicated.Headings] 'helm-schema-violation' should use sentence case.

Comment thread docs/reference/linter.mdx Outdated
<tr>
<th>Description</th>
<td>
<p>Runs <code>helm lint</code> against each Helm chart archive in the release that is referenced by a HelmChart custom resource, using the chart's default values merged with <code>spec.builder</code> values from the HelmChart custom resource. Surfaces any violations reported by Helm, including JSON schema validation errors from the chart's <code>values.schema.json</code>.</p>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [vale] reported by reviewdog 🐶
[Replicated.Passive] In general, use active voice instead of passive voice ('is referenced').

Comment thread docs/reference/linter.mdx
<th>Description</th>
<td>
<p>Runs <code>helm lint</code> against each Helm chart archive in the release that is referenced by a HelmChart custom resource, using the chart's default values merged with <code>spec.builder</code> values from the HelmChart custom resource. Surfaces any violations reported by Helm, including JSON schema validation errors from the chart's <code>values.schema.json</code>.</p>
<p>Each top-level violation is reported as a separate finding so that individual schema errors are easier to read and address.</p>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [vale] reported by reviewdog 🐶
[Replicated.Passive] In general, use active voice instead of passive voice ('is reported').

Comment thread docs/reference/linter.mdx Outdated
<tr>
<th>Applies To</th>
<td>
Helm v3 and above chart archives (<code>*.tar.gz</code>) that have a matching HelmChart custom resource manifest file with <code>kind: HelmChart</code> and <code>apiVersion: kots.io/v1beta1</code>. HelmChart custom resources with <code>helmVersion: v2</code> are skipped.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[Replicated.PositionalLanguage] Avoid spacial and directional language like 'above'. Instead, use 'on this page', 'the following', or link to the section.

Comment thread docs/reference/linter.mdx Outdated
<tr>
<th>Applies To</th>
<td>
Helm v3 and above chart archives (<code>*.tar.gz</code>) that have a matching HelmChart custom resource manifest file with <code>kind: HelmChart</code> and <code>apiVersion: kots.io/v1beta1</code>. HelmChart custom resources with <code>helmVersion: v2</code> are skipped.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [vale] reported by reviewdog 🐶
[Replicated.Passive] In general, use active voice instead of passive voice ('are skipped').

banjoh and others added 2 commits May 6, 2026 19:53
Signed-off-by: Evans Mungai <evans@replicated.com>
Comment thread docs/reference/linter.mdx
<tr>
<th>Description</th>
<td>
<p>Runs <code>helm lint</code> against each Helm chart archive in the release that is referenced by a HelmChart custom resource. Uses the chart's default values merged with <code>spec.builder</code> values from the HelmChart custom resource. Surfaces any violations reported by Helm, including JSON schema validation errors from the chart's <code>values.schema.json</code>.</p>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [vale] reported by reviewdog 🐶
[Replicated.Passive] In general, use active voice instead of passive voice ('is referenced').

Comment thread docs/reference/linter.mdx
<tr>
<th>Applies To</th>
<td>
Helm v3 and later chart archives (<code>*.tar.gz</code>) that have a matching HelmChart custom resource. HelmChart custom resources with <code>helmVersion: v2</code> are skipped.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [vale] reported by reviewdog 🐶
[Replicated.Passive] In general, use active voice instead of passive voice ('are skipped').

@banjoh banjoh merged commit 7887417 into main May 8, 2026
5 checks passed
@banjoh banjoh deleted the evansmungai/sc-136401/replicated-registry-injects-global-replicated branch May 8, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type::docs Improvements or additions to documentation type::feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants