Add HelmChart manifest validation for linter #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validates that every configured Helm chart has a corresponding HelmChart manifest (kind: HelmChart). This ensures templates can be properly rendered with builder values during preflight checks. Key changes: - New validation layer with batch error reporting for missing manifests - Refactored extraction to consolidate HelmChart discovery (eliminates duplicate calls) - Separated discovery (lenient) from validation (strict) layers - Added auto-discovery support for HelmChart manifests - Made manifest paths optional in config (validation happens at runtime) The validation runs after resource discovery but before linting, catching configuration errors early with clear, actionable error messages.
Adds unit tests, integration tests, CLI tests, and documentation for the chart-to-HelmChart manifest validation feature to ensure correctness and provide clear guidance for users. Changes: - Add 11 unit tests in validation_test.go covering all validation scenarios - Add 6 integration tests in validation_integration_test.go with test fixtures - Add 3 CLI integration tests in lint_test.go for end-to-end validation - Create 6 test scenario fixtures in testdata/validation/ - Add HelmChart Manifest Requirements section to docs/lint-format.md - Update existing tests to reflect lenient discovery pattern The tests cover success cases, error cases (single and batch), warnings for orphaned manifests, auto-discovery mode, and edge cases. Documentation includes configuration examples, validation behavior, error messages, and troubleshooting guidance.
NoaheCampbell
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds validation to ensure every Helm chart configured in
.replicatedhas a corresponding HelmChart manifest (custom resource withkind: HelmChart).How Validation Works
Two-Phase Design: Lenient Discovery + Strict Validation
The validation uses a separation of concerns approach:
DiscoverHelmChartManifests()scans manifest paths and returns whatever it finds. If no manifests are configured or no HelmCharts exist, it returns an empty map withouterrors. This allows mixed directories and makes the discovery layer flexible.
ValidateChartToHelmChartMapping()enforces the requirement that every chart has a corresponding HelmChart manifest. This is where errors are reported.Changes
ValidateChartToHelmChartMapping()function with batch error reportingValidation Behavior