fix: use EachLike for eventTypes array in notification pact test#711
Merged
alicenstar merged 3 commits intomainfrom May 1, 2026
Merged
fix: use EachLike for eventTypes array in notification pact test#711alicenstar merged 3 commits intomainfrom
alicenstar merged 3 commits intomainfrom
Conversation
The previous matcher required exactly 1 item in the eventTypes array. EachLike matches any array with at least 1 item of the correct structure, which is the correct contract — we care about the shape, not the count.
divolgin
previously approved these changes
May 1, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f8be328. Configure here.
divolgin
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /v3/notification_event_typesto usedsl.EachLikeinstead of a fixed-length sliceq=releasereturns all 5 release event types — any of which is a valid matchfiltersfrom the contract since filter structure varies per event type and isn't part of the CLI's contract concernShortcut story: https://app.shortcut.com/replicated/story/135446/cli-support-for-notification-management
Test plan
make-pact-testswill publish the updated pact to PactFlowpact-provider-verify (mainBranch: true)will pick up the new pact and should now pass