fix(cli): customer inspect does not surface isHelmInstallEnabled field#745
Open
kriscoleman wants to merge 3 commits into
Open
fix(cli): customer inspect does not surface isHelmInstallEnabled field#745kriscoleman wants to merge 3 commits into
kriscoleman wants to merge 3 commits into
Conversation
The Customer struct only mapped to the retired isHelmVmDownloadEnabled JSON tag, which the Vendor API no longer returns. This caused `customer inspect --output json` to silently drop the isHelmInstallEnabled value. Add the field so the CLI correctly deserializes and surfaces it. Fixes: https://app.shortcut.com/replicated/story/137962 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…tallEnabled Adds regression tests proving isHelmInstallEnabled deserializes correctly from JSON into the Customer struct and appears in JSON output. Covers unmarshal, marshal, round-trip, backwards compat for isHelmVmDownloadEnabled, and end-to-end CustomerAttrs JSON rendering. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
xavpaice
approved these changes
May 25, 2026
Member
xavpaice
left a comment
xavpaice
left a comment
There was a problem hiding this comment.
LGTM, appreciate adding the tests. We add tests here specifically for IsHelmInstallEnabled and a more broad test also, are the specific tests redundant?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsHelmInstallEnabledfield withjson:"isHelmInstallEnabled"tag to theCustomerstruct inpkg/types/customer.goisHelmInstallEnabledin customer responses, but the CLI was only mapping to the retiredisHelmVmDownloadEnabledtag — causingcustomer inspect --output jsonto silently drop the valueRoot Cause
The
Customerstruct had no field forisHelmInstallEnabled. Go's JSON unmarshaler silently ignores unknown keys, so the API response value was lost.Test Plan
replicated customer create --helm-install ...followed byreplicated customer inspect --output jsonnow includesisHelmInstallEnabled: trueisHelmVmDownloadEnabledfield preserved for backwards compatibilitygo build ./...passesgo test ./pkg/types/... ./cli/print/...passesFixes: [sc-137962]
🤖 Generated with Claude Code