Skip to content

Removed the static lookup code from critical path#10

Merged
airportyh merged 1 commit intomainfrom
th-remove-embedded-registry-lookup
Feb 9, 2024
Merged

Removed the static lookup code from critical path#10
airportyh merged 1 commit intomainfrom
th-remove-embedded-registry-lookup

Conversation

@airportyh
Copy link
Copy Markdown
Collaborator

Why

We found that there's currently not a practical way to make the cacache disk available in deployments, so we are going to disable the static channel-based look up for now. Relying on REPLIT_LD_LIBRARY_PATH only will still be beneficial if the follow hypothesis is true:

  • as long as the Nix channel of the entrypoint binary (python3 or node) is later than the Nix channel of a dynamically loaded shared object, the likelihood of breakage is low.

So test cases have shown this to be true. I plan to conduct some experiments to test this more.

Changes

  1. Removed call to lookup_by_channel
  2. Removed code for dynamic Nix channel detection.
  3. Updated integration test to match

@airportyh airportyh requested review from a team and cdmistman and removed request for a team February 8, 2024 16:29
Copy link
Copy Markdown

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 🤞 that hypothesis holds!

@airportyh airportyh merged commit 1c55c2f into main Feb 9, 2024
airportyh added a commit that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants