chore/decompose monolithic client gen #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blast-hardcheese
requested review from
masad-frost
and removed request for
a team
blast-hardcheese
force-pushed
the
dstewart/chore/decompose-monolithic-client-gen
branch
from
028e4a0 to
ea00715
Compare
blast-hardcheese
force-pushed
the
dstewart/chore/decompose-monolithic-client-gen
branch
from
ea00715 to
474644b
Compare
blast-hardcheese
deleted the
dstewart/chore/decompose-monolithic-client-gen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Some clients end up with tens of thousands of lines per file. This causes some difficulty for typecheckers (in particular, pyright). Decompose into services to get some breathing room.
What changed
Test plan
Does typechecking improve? ✅