Stricter error types #141
Merged
Stricter error types #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type the type adapters properly
airportyh
requested review from
blast-hardcheese and
jackyzha0
and removed request for
a team
Merged
tests/codegen/snapshot/snapshots/test_unknown_enum/enumService/needsEnum.py
Show resolved
Hide resolved
Co-authored-by: Devon Stewart <devon.stewart@repl.it>
airportyh
commented
Mar 20, 2025
blast-hardcheese
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Have the generated code return error types that actually satisfy the
ErrorType. Previously the union type for error types generated can be values ofRiverUnknownValuewhich is not an error type. This introduces aRiverUnknownErrorand uses that in the error unions instead. Also type adapter types are now more strictly typed.Testing
When switching the client code over, we should get errors about
RiverUnknownErrornot being handled and force you to fix them.