[bug] type adapter bugfix #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blast-hardcheese
requested review from
jackyzha0
and removed request for
a team
blast-hardcheese
force-pushed
the
dstewart/bug/type-adapter-bugfix
branch
from
689c034 to
8cd8c8c
Compare
airportyh
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We missed a few places where we don't include
RiverErrorin the emitted events, leading to codegen not passing typechecking.What changed
Patch in
| RiverErrorin those cases where it is mandatory so at least we won't forget it.Test plan
Describe what you did to test this change to a level of detail that allows your reviewer to test it