[chore] feat/dethread clientserver #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blast-hardcheese
requested review from
jackyzha0
and removed request for
a team
blast-hardcheese
force-pushed
the
dstewart/feat/dethread-clientserver
branch
from
a21df17 to
f9a33f3
Compare
masad-frost
reviewed
Mar 19, 2025
masad-frost
approved these changes
Mar 19, 2025
Member
masad-frost
left a comment
masad-frost
left a comment
There was a problem hiding this comment.
LGTM, every comment i was about to leave was already in existing code and we don't wanna deal with that now lol
Member
|
I had attempted to do this, and i found it my stashes, then ended up just doing this #85 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It's challenging to reason about how all the bits fit together right now.
What changed
Dethread server and client sessions and transport.
Test plan
CI