Skip to content

chore/v1 improvements #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blast-hardcheese merged 29 commits into from
Mar 30, 2025
Merged

chore/v1 improvements #149

blast-hardcheese merged 29 commits into from
Mar 30, 2025

Conversation

@blast-hardcheese
Copy link
Contributor

@blast-hardcheese blast-hardcheese commented Mar 28, 2025

Why

Split out of #106 for readability

What changed

  • Code organization
  • Tooling tweaks
  • Removing useless Locks

Test plan

CI
river-babel

@blast-hardcheese
lint tests as well
1ae427c
@blast-hardcheese
Permit method filtering based on supplied file
76f9d3a
@blast-hardcheese
Missing invocation of validate_python
bbd2049
@blast-hardcheese
inline add_msg_to_stream
64b1b89
@blast-hardcheese
Moving STREAM_CLOSED_BIT into v1 session objects for clarity in prepa…
90016ee 
…ration for v2
@blast-hardcheese
parse_transport_msg should just return a value
7d3b6ba
@blast-hardcheese
Switch from IgnoreMessageException to IgnoreMessage return value
4d86045
@blast-hardcheese
Missing ws.close()
607bacf
@blast-hardcheese
Distribute PROTOCOL_VERSION through the different files it belongs in
c2ecb77
@blast-hardcheese
Moving setup_heartbeat to session.py
0775f21
@blast-hardcheese
Representing a richer tapestry of SessionState
84a480b
@blast-hardcheese
We have nanoid types
dabc4b8
@blast-hardcheese
Move check_to_close_session over to session
e6dddb4
@blast-hardcheese
Turns out none of this was async anyhow
5c3b91a
@blast-hardcheese
Flattening unnecessary wrapper function
d6650e7
@blast-hardcheese
Unused
b1f41b6
@blast-hardcheese
Splitting has_capacity from put()
b3a22b0
@blast-hardcheese
Dedicated method for getting the next seq from the buffer
d40ec18
@blast-hardcheese
Reflowing message_buffer locks
ac95b8e
@blast-hardcheese
Fix from_ alias type hinting
a4e375e
@blast-hardcheese
Fix test_rpc codegen invocation
e526264 
Module-level imports cause unrecoverable errors on test failure
@blast-hardcheese
Use binary literal instead of hex literal for alignment with PROTOCOL.md
a384231
@blast-hardcheese
Equivalent
85e63cd
@blast-hardcheese
Useless lock
9880be7
@blast-hardcheese
Unused
525d9ac
@blast-hardcheese
More field types
e591d11
@blast-hardcheese blast-hardcheese requested a review from a team as a code owner March 28, 2025 06:18
@blast-hardcheese blast-hardcheese requested review from ryantm and removed request for a team and ryantm March 28, 2025 06:18
masad-frost
masad-frost reviewed Mar 28, 2025
View reviewed changes
@blast-hardcheese
Copy link
Contributor Author

blast-hardcheese commented Mar 30, 2025

Additional commits were issues raised by river-babel

@blast-hardcheese blast-hardcheese merged commit fa382a7 into main Mar 30, 2025
3 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/chore/v1-improvements branch March 30, 2025 17:30
@blast-hardcheese blast-hardcheese added the bug Something isn't working label Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masad-frost masad-frost masad-frost approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blast-hardcheese @masad-frost