[bug] Address proactive reconnect codepaths #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blast-hardcheese
requested review from
cbrewster and
jackyzha0
and removed request for
a team
cbrewster
approved these changes
Apr 28, 2025
jackyzha0
approved these changes
Apr 28, 2025
Member
jackyzha0
left a comment
jackyzha0
left a comment
There was a problem hiding this comment.
commented irl re: assigning self._terminating_task, rest lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We're seeing some connectivity issues using the river v2 client. Scrutinizing codepaths, there were some missed cases
What changed
_recv_from_wsshould catch all exceptions inside the loop instead of terminating early and never restartingConnectionClosedOKandConnectionClosedin exception handlers. If we close on purpose, don't initiate reconnectsession.close()should block all callers until we are down, instead of just the initiating caller.Test plan
CI/CD