Skip to content

make out-of-order non-fatal#56

Merged
jackyzha0 merged 4 commits intomainfrom
jackyzha0/non-fatal-out-of-order
Jul 26, 2024
Merged

make out-of-order non-fatal#56
jackyzha0 merged 4 commits intomainfrom
jackyzha0/non-fatal-out-of-order

Conversation

@jackyzha0
Copy link
Copy Markdown
Member

Why

Describe what prompted you to make this change, link relevant resources: Linear issues, Slack discussions, etc.

What changed

  • no longer raise protocol error on out of order and instead close the connection
    • the reasoning is that the client will attempt to re-establish the connection and re-agree on the right seq number and resend the send buffer
    • if theres a disagreement at this stage, we will kill the session but otherwise we can actually transparently recover!

Test plan

Describe what you did to test this change to a level of detail that allows your reviewer to test it

@jackyzha0 jackyzha0 requested a review from zhenthebuilder July 26, 2024 17:15
@jackyzha0 jackyzha0 changed the title make out-of-order non-fatal (curse menlo security) make out-of-order non-fatal Jul 26, 2024
@jackyzha0 jackyzha0 merged commit 2154c9b into main Jul 26, 2024
@jackyzha0 jackyzha0 deleted the jackyzha0/non-fatal-out-of-order branch July 26, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants