Check for malformed ctx.from ids in clients#379
Merged
Conversation
Monkatraz
force-pushed
the
brn-check-for-broken-from-id-from-clients
branch
from
36b3b15 to
24ff025
Compare
wernst
approved these changes
May 31, 2026
lhchavez
reviewed
May 31, 2026
Contributor
lhchavez
left a comment
lhchavez
left a comment
There was a problem hiding this comment.
lgtm, but we should try to remove those fields
| const parsedMsg = parsedMsgRes.value; | ||
|
|
||
| // messages must originate from this session's peer | ||
| if (parsedMsg.from !== this.to) { |
Contributor
There was a problem hiding this comment.
why do we even allow connections to specify the to/from? i think this is a vestigial feature that we never ended up using.
Contributor
Author
There was a problem hiding this comment.
I believe you're correct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A broken client could send messages as the wrong
fromand cause things to break.What changed
validate, a server can check the transport identity and ensure binding of the ID is valid.Versioning