Add newCgroupNamespace option to isolate shell cgroup subtree#98
Merged
jasondellaluce merged 1 commit intomainfrom Mar 12, 2026
Merged
Conversation
cbrewster
approved these changes
Mar 12, 2026
Member
cbrewster
left a comment
cbrewster
left a comment
There was a problem hiding this comment.
Nice, I suspect this won't work without goval 3 since we block unshare. I wonder if there's a way we can enable this but gracefully fall back? Once we're on goval 3 we can make this error if the syscall fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to optionally make a PTY unshare to a new cgroup namespaces. This allows better isolation that prevents "breakout" attempts where a shell session attempts joining another cgroup scope out of its own subtree.