feat: Improve search ui, add offsets to dab search#1
Conversation
|
Oh, and i also added a regenerated bun.lock to fix freeman-jiang#21 |
replydev
left a comment
There was a problem hiding this comment.
Hello @MalTeeez, thanks for your changes.
I think we are missing the actual part that handles the offset parameter, in DOWNLOAD_SERVICE (maybe you forgot to commit?)
Then, I sent just a simple request change, but as far as I saw from your screenshot, this is pretty good!
Finally, I guess we need a proper prettier / biome config to handle formatting, because most of the changes are indents and a bit difficult to review.
I will check this hands on, today.
Yep, seems they were missing somehow - working across 3 repositories & multiple branches is getting a little tricky. I also added tooltips for list elements, in case some titles / albums get too long.
Totally agree, but probably something for upstream to start in a new PR. |
|
The whole component does still need to be improved for mobile, it turns unusable as soon as the control components leave the screen.. |
For mobile we could use the credenza component, you can find it on Github. It's basically a wrapper that chooses which component to use given the screen size. Ofc it's not needed here, but as a further enhancement later on 👍. |
This PR implements the UI changes as presented in the upstream PR freeman-jiang#18.
It also adds the search with offset functionality needed for the pagination controls along the necessary backend features and some refactoring of the download / search interface for future usage.