This repository was archived by the owner on Apr 10, 2018. It is now read-only.
Merged
Conversation
Member
|
Where are generated files? |
xferra
suggested changes
May 19, 2017
Member
xferra
left a comment
xferra
left a comment
There was a problem hiding this comment.
- Generated classes should have proper namespaces
- Documentation for properties should start with 'Gets or sets'
- Generate documentation for Enums
xferra
reviewed
May 20, 2017
| //process.exit(1); | ||
| } | ||
| fs.writeFileSync(path.join(integration, 'actual', file + ".log"), stdout); | ||
| var actualDir = path.join(integration, 'actual'); |
Member
There was a problem hiding this comment.
This "if" could be moved to the start - there is no reason to check this folder for every test.
ghost
deleted the
romanrostislavovich
pushed a commit
to romanrostislavovich/linterhub-cli
that referenced
this pull request
Mar 29, 2018
* Add c# generator * Update shemas and generator * Update integration tests * Use Path instead of filePath, update reporters and tests * disable sass-lint tests * Fix analyze results sort * Create actual dir if doesnt exist * Update coffeelint tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50