Feature - Props API Improvements#14
Closed
Smithor wants to merge 1 commit into
Closed
Conversation
Owner
|
This submission makes a good point - using varargs for key/values is potentially error prone and bad form. With a map param it would be better defined and could still be called with setPropValues(Map.of(key, val, ...)). I noticed that I don't use that method anywhere though, so I think the best course of action is just to remove it (which I did). It can easily be replicated with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A collection of API improvements working through the props package. Might include documentation, method contracts, or anything else related. Issues raised as part of this pull request will be blockers, and their solution commits will be appended when resolved.
Blockers: