EPMRPP-114114 || Update S3 Cloud Storage doc#1101
EPMRPP-114114 || Update S3 Cloud Storage doc#1101maria-hambardzumian merged 1 commit intodevelopfrom
Conversation
WalkthroughThe S3CloudStorage.md documentation file is updated to explicitly include Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/installation-steps-advanced/file-storage-options/S3CloudStorage.md`:
- Around line 369-370: The ES_HOSTS env entry currently contains HTML anchor
markup which is invalid for configuration; update the ES_HOSTS value to a plain
URL string (e.g., "http://opensearch:9200") so the analyzer can parse/connect
correctly, leaving DATASTORE_TYPE: s3 unchanged and ensuring ES_HOSTS contains
no HTML or tags.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e0fc6963-a89c-4c1a-a674-3f1aea851f61
📒 Files selected for processing (1)
docs/installation-steps-advanced/file-storage-options/S3CloudStorage.md
| ES_HOSTS: <a href="http://opensearch:9200" rel="noreferrer noopener" title="http://opensearch:9200/" target="_blank">http://opensearch:9200</a> | ||
| DATASTORE_TYPE: s3 |
There was a problem hiding this comment.
Use plain URL for ES_HOSTS (HTML markup breaks config).
Line 369 should stay a raw host string. The current anchor tag value is not a valid ES_HOSTS env value and can break analyzer startup/connectivity.
Suggested fix
- ES_HOSTS: <a href="http://opensearch:9200" rel="noreferrer noopener" title="http://opensearch:9200/" target="_blank">http://opensearch:9200</a>
+ ES_HOSTS: http://opensearch:9200
DATASTORE_TYPE: s3📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ES_HOSTS: <a href="http://opensearch:9200" rel="noreferrer noopener" title="http://opensearch:9200/" target="_blank">http://opensearch:9200</a> | |
| DATASTORE_TYPE: s3 | |
| ES_HOSTS: http://opensearch:9200 | |
| DATASTORE_TYPE: s3 |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/installation-steps-advanced/file-storage-options/S3CloudStorage.md`
around lines 369 - 370, The ES_HOSTS env entry currently contains HTML anchor
markup which is invalid for configuration; update the ES_HOSTS value to a plain
URL string (e.g., "http://opensearch:9200") so the analyzer can parse/connect
correctly, leaving DATASTORE_TYPE: s3 unchanged and ensuring ES_HOSTS contains
no HTML or tags.
Summary by CodeRabbit