Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a static method elementExists to the Pipeline class, enabling developers to check for GStreamer element availability before using them in pipelines. This is useful for feature detection, graceful degradation, and selecting alternative encoders/decoders based on system capabilities.
Key Changes:
- Added
Pipeline.elementExists(elementName: string): booleanstatic method to check GStreamer element availability - Refactored GStreamer initialization to be reusable across instance and static methods
- Added comprehensive test coverage for various element types and edge cases
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/ts/index.ts | Added PipelineConstructor interface with elementExists method signature |
| src/cpp/pipeline.hpp | Added static ElementExists method declaration and GStreamer initialization helpers |
| src/cpp/pipeline.cpp | Implemented ElementExists with proper memory management and error handling |
| src/ts/element-exists.test.ts | Added comprehensive test suite covering common elements, edge cases, and error conditions |
| examples/element-exists.mjs | Added example demonstrating practical usage for encoder selection |
| README.md | Added documentation section with usage examples and API reference update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.