Skip to content

Collect and log/report generic binding errors and type load errors from connectors#157

Merged
gasparnagy merged 3 commits intomainfrom
collect-and-report-binding-errors-and-logs-from-connector
Jan 28, 2026
Merged

Collect and log/report generic binding errors and type load errors from connectors#157
gasparnagy merged 3 commits intomainfrom
collect-and-report-binding-errors-and-logs-from-connector

Conversation

@gasparnagy
Copy link
Contributor

@gasparnagy gasparnagy commented Jan 27, 2026

🤔 What's changed?

The binding errors and type load errors that were received by the connector from Reqnroll were not captured and displayed in VS. This change logs type load errors and shows generic binding errors on the error list. It also shows warnings, but that ones are currently not used.

⚡️ What's your motivation?

Better see when the discovery passed with a type load error (related to reqnroll/Reqnroll#1006)

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

Tested it manually

📋 Checklist:

  • I've changed the behaviour of the code
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

@gasparnagy gasparnagy marked this pull request as ready for review January 27, 2026 18:08
@gasparnagy gasparnagy requested a review from clrudolphi January 27, 2026 18:09
Copy link
Contributor

@clrudolphi clrudolphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should I go about validating that this is working? I have tried running this from the Experimental Hive instance and loading the MSDI sample project we have, but I see no change in behavior (only the single Error List warning entry about bindings not discovered).

@gasparnagy
Copy link
Contributor Author

gasparnagy commented Jan 28, 2026

How should I go about validating that this is working? I have tried running this from the Experimental Hive instance and loading the MSDI sample project we have, but I see no change in behavior (only the single Error List warning entry about bindings not discovered).

Ah yes. The two improvements you can try:

  • Open the sample project for issue TestDB.dbml breaks navigation #72, using Reqnroll v3.3.3 (so your fix included). The discovery should work and you should see a log entry in the output pane saying that some types or members are skipped because of a type load error.
  • Make a [BeforeTestRun] hook, but don't make the method static. Build the project, the discovery should run and you should see an error in the error dialog saying that the method has to be made static. (This is currently a "generic binding error")

@clrudolphi
Copy link
Contributor

  • Open the sample project for issue TestDB.dbml breaks navigation #72, using Reqnroll v3.3.3 (so your fix included). The discovery should work and you should see a log entry in the output pane saying that some types or members are skipped because of a type load error.
  • Make a [BeforeTestRun] hook, but don't make the method static. Build the project, the discovery should run and you should see an error in the error dialog saying that the method has to be made static. (This is currently a "generic binding error")

Ah. That explains it. I was looking for the messages in the Error List pane, not the Reqnroll Output pane.
I do now see both in the Output pane. And the error about the hook in the Error List.

Side-question: do we integrate with the C# editor to provide error indicators on the editing surface (such as red squiggles under the hook method) to indicate errors?

Copy link
Contributor

@clrudolphi clrudolphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions resolved and behavior confirmed through sample project testing.

@gasparnagy
Copy link
Contributor Author

Side-question: do we integrate with the C# editor to provide error indicators on the editing surface (such as red squiggles under the hook method) to indicate errors?

The analyzer of @Code-Grump (reqnroll/Reqnroll#541) will do that in a much nicer way that integrates to the C# editor nicely.

@gasparnagy gasparnagy merged commit 6e7d254 into main Jan 28, 2026
4 checks passed
@gasparnagy gasparnagy deleted the collect-and-report-binding-errors-and-logs-from-connector branch January 28, 2026 16:39
@gasparnagy
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants