Conversation
- Add LifecycleData.from_dict() classmethod to centralize lifecycle parsing from YAML dicts, replacing duplicated inline blocks in requirements_model_generator.py and svcs_model_generator.py - Add Utils.parse_version() to centralize version string parsing, replacing duplicated __parse_req_version and __parse_svc_version private methods - Remove unused LIFECYCLESTATE, InvalidVersion, and Version imports from both generators - Add 4 unit tests for LifecycleData.from_dict() (TDD) Signed-off-by: jimisola <jimisola@jimisola.com>
Signed-off-by: jimisola <jimisola@jimisola.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LifecycleData.from_dict()classmethod to centralize lifecycle parsing from YAML dicts, replacing duplicated inline blocks inrequirements_model_generator.pyandsvcs_model_generator.pyUtils.parse_version()to centralize version string parsing, replacing duplicated__parse_req_versionand__parse_svc_versionprivate methodsLIFECYCLESTATE,InvalidVersion, andVersionimports from both generatorsLifecycleData.from_dict()(TDD)Test plan
🤖 Generated with Claude Code