fix(ci): update release tag check to support PEP 440 pre-release versions#87
Merged
fix(ci): update release tag check to support PEP 440 pre-release versions#87
Conversation
…ions Update the tag format regex to accept all PEP 440 version identifiers: alpha (a), beta (b), release candidate (rc), post-release (.post), and dev releases (.dev), in addition to final releases (1.2.3). Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_release.ymlfrom a plain semver pattern to a full PEP 440 compliant pattern$anchor to prevent partial matches1.2.3a1(alpha),1.2.3b2(beta),1.2.3rc1(release candidate),1.2.3.post1(post-release),1.2.3.dev1(dev)Motivation
The old regex
^refs/tags/[0-9]+\.[0-9]+\.[0-9]+blocked publishing pre-release versions to PyPI, which is needed to test the publish pipeline without relying on Test PyPI.Test plan
echo "refs/tags/1.2.3a1" | grep -qE '^refs/tags/[0-9]+(\.[0-9]+)*(a[0-9]+|b[0-9]+|rc[0-9]+)?(\.post[0-9]+)?(\.dev[0-9]+)?$' && echo ok1.2.3) still passv1.2.3, bare strings) are still rejected