fix: support bare semver tags and fix check_release workflow#111
Merged
fix: support bare semver tags and fix check_release workflow#111
Conversation
- Add pattern to poetry-dynamic-versioning to match tags without v prefix - Fix check_release.yml: was a no-op (push event never fires on release) - Validate bare semver tag format (e.g. 1.2.3, not v1.2.3) - Validate release targets main, hotfix/*, or release/* branch Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CI/CD run produced
0.0.5.devXXXXinstead of0.1.0when releasing with a bare semver tag (0.1.0withoutvprefix).Root Causes
poetry-dynamic-versioningdefault pattern requiresv-prefixed tags — tag0.1.0wasn't recognized, fell back tov0.0.5+ commit distance.check_release.ymlwas a no-op: theif: github.event_name == 'push'condition is alwaysfalsewhen called viaworkflow_callfrom areleaseevent.Changes
pyproject.tomlAdded
patternto[tool.poetry-dynamic-versioning]to match bare semver tags (novprefix required):.github/workflows/check_release.yml1.2.3)main,hotfix/*,release/*)