-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Elasticsearch v8.x added #6031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Elasticsearch v8.x added #6031
Conversation
|
Please keep PRs to a single topic. A dynamic ToC is completely unrelated to the PR original goal. |
|
I just wanted to add the newly added features quickly, but I threw the two features through the same PR. Sorry it won't happen again |
| locale: r._source.locale, | ||
| path: r._source.path, | ||
| title: r._source.title, | ||
| isPublic: r._source.isPublic ? r._source.isPublic : false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That field doesn't exist... and I'm not sure why it's part of the PR either.
|
Looking at the dependencies, 8.x requires Node 14 instead of 12 in previous 7.x and 6.x versions. This could break installations for users still on 12 (which is still supported). So I'm not going to merge this PR for now. If the node requirements change in the future, I'll re-consider it. |
|
Ok, Thank you for your I help. I hope this feature can add soon as possible... |
|
That's unlucky that there are compatibility problems. It's the first time I set up Elasticsearch and used version 8 and cannot switch that easily to version 7 now.
Do you mean on local installations? Maybe the version switch can be done when Wiki.js 3 will be released. Whenever it will be. |

No description provided.