Skip to content

Conversation

@YunusEmreAlps
Copy link

No description provided.

@auto-assign auto-assign bot requested a review from NGPixel January 11, 2023 07:08
@NGPixel
Copy link
Member

NGPixel commented Jan 12, 2023

Please keep PRs to a single topic. A dynamic ToC is completely unrelated to the PR original goal.

@YunusEmreAlps
Copy link
Author

I just wanted to add the newly added features quickly, but I threw the two features through the same PR. Sorry it won't happen again

locale: r._source.locale,
path: r._source.path,
title: r._source.title,
isPublic: r._source.isPublic ? r._source.isPublic : false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That field doesn't exist... and I'm not sure why it's part of the PR either.

@NGPixel
Copy link
Member

NGPixel commented Jan 15, 2023

Looking at the dependencies, 8.x requires Node 14 instead of 12 in previous 7.x and 6.x versions. This could break installations for users still on 12 (which is still supported).

So I'm not going to merge this PR for now. If the node requirements change in the future, I'll re-consider it.

@NGPixel NGPixel added deferred Will be addressed later and removed needs-work labels Jan 15, 2023
@YunusEmreAlps
Copy link
Author

Ok, Thank you for your I help. I hope this feature can add soon as possible...

@saschabrockel
Copy link

That's unlucky that there are compatibility problems. It's the first time I set up Elasticsearch and used version 8 and cannot switch that easily to version 7 now.

This could break installations for users still on 12 (which is still supported)

Do you mean on local installations?

Maybe the version switch can be done when Wiki.js 3 will be released. Whenever it will be.

@YunusEmreAlps
Copy link
Author

Screenshot (288)

When I worked with my local environment I didn't realize but I think in the CI/CD pipeline library error deferred this update. Wiki.js main node version and elastic v8 incompatible in CI/CD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deferred Will be addressed later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants