fix missing volume mount in sideload#7963
Open
liviu-vasut wants to merge 3 commits intorequarks:mainfrom
Open
Conversation
because data is now persisted between restarts we need to clear the directory contents before cloning to avoid 'already exists and is not an empty directory' errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for the sideloading feature of the wikijs helm chart. Setting
sideload.enable: truedoes start the sideload init container and the data is fetched from the localization URL, but it is written to the container file system, which is lost after the init container completes. Hence the localization files are missing in the wiki container. The fix adds the samevolumeMountsconfigured for the wiki container to the sideload init container. Also, makes the offline mode configurable, which currently is a pain to set as true.