fix: null-guard storage targets and page tags to prevent crashes#8005
Open
derekderie wants to merge 1 commit into
Open
fix: null-guard storage targets and page tags to prevent crashes#8005derekderie wants to merge 1 commit into
derekderie wants to merge 1 commit into
Conversation
Author
|
Found the root cause of #7978 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two places in the storage layer can throw a
TypeError: Cannot read properties of undefinedwhen iterating over collections that may not be initialized:Storage.targetscan beundefinedwhen storage hasn't beenactivated/configured yet. Affects
pageEvent,assetEvent, andgetLocalLocations.currentPage.tagscan beundefinedwhen a page was imported orcreated without tags. Affects the disk storage
common.jshandler.Fix
Add
|| []fallback guards so these methods degrade gracefully instead of throwing:server/models/storage.js— 3 occurrencesserver/modules/storage/disk/common.js— 1 occurrence