chore: linux in ci

[nsrCodes]

Summary by CodeRabbit

• Chores
  • Updated build workflow configuration to enable additional platform build option.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The pull request modifies the GitHub Actions workflow configuration file for the desktop app release process. Specifically, it activates ubuntu-latest as an available option in the workflow_dispatch input build_type parameter by uncommenting an entry. The default value remains unchanged, and no other behavioral or control-flow modifications are introduced.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Single configuration file modified
• Uncommented option entry with no syntax changes
• No logic or behavioral modifications beyond enabling the option
• No exported or public declarations affected

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore: linux in ci' directly relates to the main change: activating ubuntu-latest (Linux) as an option in the CI workflow.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch add-linxu-to-release-flow

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a1fc38b and 161b758.

📒 Files selected for processing (1)

• .github/workflows/release_desktop_app.yml (1 hunks)

🔇 Additional comments (1)

.github/workflows/release_desktop_app.yml (1)

28-32: Fix the runner OS condition mismatch.

The conditional checks reference windows-2019, but the available build_type option is windows-latest. This causes:

• Line 28: The condition != 'windows-2019' will always be true for both ubuntu-latest and windows-latest selections, incorrectly setting autocrlf to input on Windows (which typically requires true).
• Line 31: The condition == 'windows-2019' will never match any available option.

Update the conditions to check for the correct runner type:

      - name: EOL autocrlf input
-       if: ${{ github.event.inputs.build_type != 'windows-2019' }}
+       if: ${{ github.event.inputs.build_type != 'windows-latest' }}
        run: git config --global core.autocrlf input
      - name: EOL autocrlf true
-       if: ${{ github.event.inputs.build_type == 'windows-2019' }}
+       if: ${{ github.event.inputs.build_type == 'windows-latest' }}
        run: git config --global core.autocrlf true

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

Enable Ubuntu as a build option. ✓

The change to uncomment ubuntu-latest is sound and enables Linux builds. However, there is a pre-existing critical issue in the workflow that should be addressed before merging.

🤖 Prompt for AI Agents

In .github/workflows/release_desktop_app.yml around line 11, you uncommented "-
ubuntu-latest" to enable Linux builds but the workflow likely still hardcodes
runs-on or lacks a proper matrix entry; update the job to use a strategy.matrix
(e.g., strategy: matrix: os: [ubuntu-latest, macos-latest, windows-latest]) and
set runs-on: ${{ matrix.os }}, remove any duplicate runner entries, ensure any
OS-specific steps/paths are guarded by if: matrix.os == '...' checks, and run
the workflow linter/validate to confirm the YAML is valid before merging.