[ENGG-2240] feat: Improve connect experience for existing browser profile in desktop app#2167
Conversation
|
Typo Code Review 📊 ✅ All checks passed! |
wrongsahil
approved these changes
Sep 17, 2024
Member
|
Experience can be improved. And should channel all the browser connect/disconnect through existing ipc instead of creating a new one. But this looks good for 1st iteration. |
l2dy
pushed a commit
to l2dy-forks/requestly
that referenced
this pull request
May 1, 2026
…file in desktop app (requestly#2167) * basic UI * added UI flow * added proxy setter * setup wss * fix: styles * added disabled states * added disconnection experience * handle appName * fix: chromium existing * fix: names and constants * remove id check * fix: message * fix: popup style * fix: multiple connections * fix: disconnection * added instructions * fix: disconnection * added blocklist check * added compatibility check * fix: bypass list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #391
Desktop App experience: requestly/http-interceptor-desktop-app#105
Demo
trimmed-.existing.browser.demo.mov