[ENGG-5243]: dynamic variables provider and resolver#4324
[ENGG-5243]: dynamic variables provider and resolver#4324rohanmathur91 merged 9 commits intoENGG-5180from
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
iostreamer-X
left a comment
iostreamer-X
left a comment
There was a problem hiding this comment.
Please add detailed documentation of what each class is doing and why.
|
|
||
| export abstract class DynamicVariableProvider { | ||
| abstract readonly name: string; | ||
| abstract readonly variables: Map<string, DynamicVariable>; |
There was a problem hiding this comment.
Given this is a map where the value is a DynamicVariable, i think this should be renamed to variableNames. Currently, this confused me as to why are we caching variable values? Only to realise that it's just a map of variable names and actual DynamicVariable
| import { DynamicVariableProvider } from "../providers"; | ||
|
|
||
| export class HandlebarsResolver extends DynamicVariableResolver { | ||
| private hbs: typeof Handlebars | null = null; |
There was a problem hiding this comment.
This property doesn't seem to be used.
…post response script (#4326) * add dynamic variables support in pre and post response scripts * update dynamic variable resolver instance name
* add DynamicVariableProvider * add faker provider * add DynamicVariableResolver * add resolver * add comment * fix: generate method * refactor * add comments * [ENGG-5246] feat: add dynamic variable support in api client pre and post response script (#4326) * add dynamic variables support in pre and post response scripts * update dynamic variable resolver instance name
2 participants
Closes issue:
📜 Summary of changes:
🎥 Demo Video:
Video/Demo:
✅ Checklist:
🧪 Test instructions:
🔗 Other references: