Skip to content

Conversation

@Afnarel
Copy link
Contributor

@Afnarel Afnarel commented Nov 28, 2014

When the TokenMissing exception is raised, a TypeError exception is raised: TypeError: super(type, obj): obj must be an instance or subtype of type.

This is because when calling the parent ValueError class, TokenRequestDenied is passed to super() instead of TokenMissing. This is probably due to a bad copy&paste from the code of the TokenRequestDenied right above.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling bd7af47 on Afnarel:fix-tokenmissing-typeerror into 23fc41b on requests:master.

@Lukasa
Copy link
Member

Lukasa commented Nov 28, 2014

Thanks for this! 🍰

Lukasa added a commit that referenced this pull request Nov 28, 2014
Fix TypeError in TokenMissing class (call to parent)
@Lukasa Lukasa merged commit 50e8529 into requests:master Nov 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants