Skip to content

Conversation

@singingwolfboy
Copy link
Member

I'm trying to instantiate an OAuth2Session object, and populate information (like client_id) after the initialization code has already run. This change is necessary for that -- otherwise, I get AttributeError: 'NoneType' object has no attribute 'client_id'

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 85.87% when pulling 1859bad on singingwolfboy:allow-setting-values-after-initialization into 50e8529 on requests:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 85.87% when pulling 1859bad on singingwolfboy:allow-setting-values-after-initialization into 50e8529 on requests:master.

@singingwolfboy
Copy link
Member Author

ping

@singingwolfboy singingwolfboy force-pushed the allow-setting-values-after-initialization branch from 1859bad to c39f2f0 Compare April 28, 2015 03:41
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 85.91% when pulling c39f2f0 on singingwolfboy:allow-setting-values-after-initialization into 5e6a88e on requests:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 85.91% when pulling c39f2f0 on singingwolfboy:allow-setting-values-after-initialization into 5e6a88e on requests:master.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be an explicit None check? if client is not None

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@singingwolfboy singingwolfboy force-pushed the allow-setting-values-after-initialization branch from c39f2f0 to f3523b9 Compare April 28, 2015 12:15
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.03%) to 84.81% when pulling f3523b9 on singingwolfboy:allow-setting-values-after-initialization into 5e6a88e on requests:master.

@singingwolfboy
Copy link
Member Author

ping

Lukasa added a commit that referenced this pull request Apr 30, 2015
…r-initialization

Check if client exists before referencing client_id
@Lukasa Lukasa merged commit 81ef170 into requests:master Apr 30, 2015
@singingwolfboy
Copy link
Member Author

@Lukasa Thanks! Any chance you can make another release on PyPI to bring this fix out to the world? (You might want to address #165 while you're at it.)

@Lukasa
Copy link
Member

Lukasa commented May 4, 2015

I've just pushed 0.5.0. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants