Skip to content

Conversation

@singingwolfboy
Copy link
Member

Because when doing automatic token refresh, we need a client_id and client_secret in order to do HTTP Basic auth. This is necessary for automatic token refresh with Bitbucket.

@coveralls
Copy link

coveralls commented Aug 27, 2016

Coverage Status

Coverage decreased (-1.7%) to 84.932% when pulling d4e0214 on singingwolfboy:oauth2-request-accept-client-id-and-secret into a116d06 on requests:master.

@singingwolfboy singingwolfboy force-pushed the oauth2-request-accept-client-id-and-secret branch from d4e0214 to a9f142c Compare August 27, 2016 21:08
@coveralls
Copy link

coveralls commented Aug 27, 2016

Coverage Status

Coverage decreased (-1.7%) to 84.932% when pulling a9f142c on singingwolfboy:oauth2-request-accept-client-id-and-secret into a116d06 on requests:master.

@singingwolfboy singingwolfboy force-pushed the oauth2-request-accept-client-id-and-secret branch from a9f142c to ce3a67b Compare August 27, 2016 21:10
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 84.932% when pulling ce3a67b on singingwolfboy:oauth2-request-accept-client-id-and-secret into a116d06 on requests:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 84.932% when pulling ce3a67b on singingwolfboy:oauth2-request-accept-client-id-and-secret into a116d06 on requests:master.

Because when doing automatic token refresh, we need a client_id and
client_secret in order to do HTTP Basic auth.
@singingwolfboy singingwolfboy force-pushed the oauth2-request-accept-client-id-and-secret branch from ce3a67b to 3348380 Compare August 27, 2016 21:13
@coveralls
Copy link

coveralls commented Aug 27, 2016

Coverage Status

Coverage increased (+0.1%) to 86.758% when pulling 3348380 on singingwolfboy:oauth2-request-accept-client-id-and-secret into a116d06 on requests:master.

@Lukasa
Copy link
Member

Lukasa commented Sep 18, 2016

Thanks @singingwolfboy, this looks good to me! ✨ Sorry about the delay!

@Lukasa Lukasa merged commit e85617a into requests:master Sep 18, 2016
@singingwolfboy
Copy link
Member Author

@Lukasa Thanks! Would you mind releasing a new version of requests-oauthlib? I have a pull request to Flask-Dance that depends on this code, and I can't merge that PR until I can modify the requirements.txt file to point to a version of requests-oauthlib that has this change.

@Lukasa
Copy link
Member

Lukasa commented Sep 18, 2016

Sure, I'll aim to release sometime this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants