-
-
Notifications
You must be signed in to change notification settings - Fork 426
Allow OAuth2 session request() to take client_id and client_secret #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Lukasa
merged 1 commit into
requests:master
from
singingwolfboy:oauth2-request-accept-client-id-and-secret
Sep 18, 2016
Merged
Allow OAuth2 session request() to take client_id and client_secret #251
Lukasa
merged 1 commit into
requests:master
from
singingwolfboy:oauth2-request-accept-client-id-and-secret
Sep 18, 2016
+29
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4e0214 to
a9f142c
Compare
a9f142c to
ce3a67b
Compare
1 similar comment
Because when doing automatic token refresh, we need a client_id and client_secret in order to do HTTP Basic auth.
ce3a67b to
3348380
Compare
This was referenced Aug 27, 2016
Member
|
Thanks @singingwolfboy, this looks good to me! ✨ Sorry about the delay! |
Member
Author
|
@Lukasa Thanks! Would you mind releasing a new version of |
Member
|
Sure, I'll aim to release sometime this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because when doing automatic token refresh, we need a
client_idandclient_secretin order to do HTTP Basic auth. This is necessary for automatic token refresh with Bitbucket.