Remove range operators from markers.#4014
Merged
Lukasa merged 1 commit intopsf:masterfrom May 10, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4014 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 15 15
Lines 1940 1940
=======================================
Hits 1741 1741
Misses 199 199Continue to review full report at Codecov.
|
nateprewitt
approved these changes
May 10, 2017
Member
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
I tested this with a couple of the repositories that were still experiencing failures after #4007 , and things are operating as expected now.
It seems setuptools 12 is the oldest version we've seen reports for, so this should solve the rest of the reports that have trickled in.
Member
Author
|
Cool, ok. Let's ship a 2.14.2 with this and see if this cleans up the last few lingering pain points. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4013.
It turns out that older setuptools were pretty stupid and couldn't handle range operators, but they can handle parentheses and the word "or". So let's do that instead.