Skip to content

fix(document): fix editor crash on missing provisionActivity model#1095

Open
PascalRepond wants to merge 1 commit intorero:stagingfrom
PascalRepond:rep-fix-editor
Open

fix(document): fix editor crash on missing provisionActivity model#1095
PascalRepond wants to merge 1 commit intorero:stagingfrom
PascalRepond:rep-fix-editor

Conversation

@PascalRepond
Copy link
Contributor

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

Warning

Rate limit exceeded

@PascalRepond has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 40 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 07cbd4e2-6d30-47cc-8cfe-f17f2265ab16

📥 Commits

Reviewing files that changed from the base of the PR and between c874c7e and 1c6aeb6.

📒 Files selected for processing (2)
  • scripts/test
  • sonar/modules/documents/jsonschemas/documents/document-v1.0.0.json

Walkthrough

Adds three vulnerability exceptions to py-audit checks for pyjwt and tornado, and changes a JSON Schema provisioning UI condition to use optional chaining for evaluating the parent model type.

Changes

Cohort / File(s) Summary
Test Vulnerability Exceptions
scripts/test
Appends three new add_exceptions entries: CVE-2026-32597 (pyjwt 2.11.0–2.12.0), GHSA-78cv-mqj4-43f7 (tornado 6.5.4–6.5.5), and CVE-2026-31958 (tornado 6.5.4–6.5.5). No control-flow or signature changes.
JSON Schema Condition
sonar/modules/documents/jsonschemas/documents/document-v1.0.0.json
Replaces a dependent-type visibility expression with optional chaining: field.parent.model?.type !== 'bf:Publication', treating missing type as a comparable value.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a description explaining the crash scenario, why the optional-chaining fix resolves it, and any testing performed to validate the fix.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main fix: addressing an editor crash caused by missing provisionActivity model, which directly relates to the JSON schema change for handling missing type values.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]

This comment was marked as outdated.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant