Skip to content

Use ": " separator in re_error::format to match anyhow's {:#} format #11830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

Use ": " separator in re_error::format to match anyhow's {:#} format #11830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions crates/utils/re_error/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@ pub fn format(error: impl AsRef<dyn std::error::Error>) -> String {
///
/// Always use this when displaying an error, especially `anyhow::Error`.
pub fn format_ref(error: &dyn std::error::Error) -> String {
// Use ": " as separator to match anyhow's `format!("{:#}", err)` output
// See: https://github.com/rerun-io/rerun/issues/8681
let mut string = error.to_string();
for source in std::iter::successors(error.source(), |error| error.source()) {
string.push_str(" -> ");
string.push_str(": ");
string.push_str(&source.to_string());
}
string
Expand All @@ -28,5 +30,5 @@ fn test_format() {
assert_eq!(err.to_string(), "outer_context"); // Oh no, we don't see the root cause!

// Now we do:
assert_eq!(format(&err), "outer_context -> inner_context -> root_cause");
assert_eq!(format(&err), "outer_context: inner_context: root_cause");
}
Loading