Skip to content

Add .res/.resi to vite ignore list to fix fast refresh#125

Merged
fhammerschmidt merged 1 commit intomasterfrom
fast-refresh-vite7-fix
Apr 30, 2026
Merged

Add .res/.resi to vite ignore list to fix fast refresh#125
fhammerschmidt merged 1 commit intomasterfrom
fast-refresh-vite7-fix

Conversation

@fhammerschmidt
Copy link
Copy Markdown
Member

No description provided.

@fhammerschmidt fhammerschmidt requested a review from tsnobip April 29, 2026 21:13
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 29, 2026

Open in StackBlitz

npx https://pkg.pr.new/create-rescript-app@125

commit: 7fd4d74

Comment thread templates/rescript-template-vite/vite.config.js Outdated
Comment thread rollup.config.mjs Outdated
@fhammerschmidt fhammerschmidt force-pushed the fast-refresh-vite7-fix branch from 5c23a22 to 144422d Compare April 30, 2026 09:31
@fhammerschmidt fhammerschmidt changed the title Add plugin to fix fast refresh with vite 7 Use JSX preserve mode to support fast refresh Apr 30, 2026
@fhammerschmidt fhammerschmidt force-pushed the fast-refresh-vite7-fix branch 2 times, most recently from 0d1876d to bb06e90 Compare April 30, 2026 10:07
@fhammerschmidt fhammerschmidt changed the title Use JSX preserve mode to support fast refresh Add .res/.resi to vite ignore list to fix fast refresh Apr 30, 2026
@fhammerschmidt fhammerschmidt force-pushed the fast-refresh-vite7-fix branch from bb06e90 to 96f1e91 Compare April 30, 2026 10:11
Comment thread templates/rescript-template-vite/vite.config.js Outdated
Copy link
Copy Markdown
Member

@tsnobip tsnobip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is gonna harden our base apps so much, thanks @fhammerschmidt!

Comment thread test/ViteTemplateFastRefreshTest.res Outdated
@tsnobip
Copy link
Copy Markdown
Member

tsnobip commented Apr 30, 2026

oh one last thing you could clean while you're there, I think this line can be removed too in index.html:

- <link href="/dist/styles.css" rel="stylesheet">

I think it's useless anyway and it creates a console error.

@fhammerschmidt fhammerschmidt force-pushed the fast-refresh-vite7-fix branch from 96f1e91 to ae5dab0 Compare April 30, 2026 11:33
@fhammerschmidt fhammerschmidt force-pushed the fast-refresh-vite7-fix branch from ae5dab0 to 7fd4d74 Compare April 30, 2026 11:35
@fhammerschmidt
Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fhammerschmidt fhammerschmidt requested a review from cknitt April 30, 2026 12:22
@fhammerschmidt fhammerschmidt merged commit 3c504c0 into master Apr 30, 2026
8 checks passed
@fhammerschmidt fhammerschmidt deleted the fast-refresh-vite7-fix branch April 30, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants